[GH-211] Try parsing the response using JSON.parse after performing Typesense request#212
Open
nguyenkhavi wants to merge 1 commit intotypesense:masterfrom
Open
[GH-211] Try parsing the response using JSON.parse after performing Typesense request#212nguyenkhavi wants to merge 1 commit intotypesense:masterfrom
JSON.parse after performing Typesense request#212nguyenkhavi wants to merge 1 commit intotypesense:masterfrom
Conversation
…ios fetch adapter
JSON.parse after performing Typesense request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
As @cungminh2710 already mentioned on this pull request,
typesense-jswill use the Axios fetch adapter in the case of Edge Runtime like Cloudflare. The Axios fetch adapter returns a string instead of a parsed object in the response body.I added some lines of code to try parsing the response using
JSON.parseafter performing Typesense request:Close GH-211
PR Checklist